Issue #51022: Improve E0131 message when lifetimes are involved. #51084
Conversation
|
r? @cramertj (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
| // except according to those terms. | ||
|
|
||
| // error-pattern: `main` function is not allowed to have lifetime parameters | ||
| fn main<'a>() { } |
There was a problem hiding this comment.
Instead of using error-pattern you can add below a line with
//~^ ERROR `main` function is not allowed to have lifetime parameters
instead.
Also, I'd prefer new tests to be ui instead of just compile-fail. That way we also test the visual output.
There was a problem hiding this comment.
Makes sense. Will do this is in a follow-up PR.
There was a problem hiding this comment.
Follow-up PR at #51108
| "lifetime" | ||
| } else { | ||
| "type" | ||
| }; |
There was a problem hiding this comment.
Intrigued as to what the output is when you have fn main<'a, T>() {}.
There was a problem hiding this comment.
It would say lifetime, because one of the parameters is a lifetime. Would you go "lifetime nor type" parameters in such a case?
|
@bors r+ rollup |
|
📌 Commit 023137d has been approved by |
bors
added
S-waiting-on-bors
|
💔 Test failed - status-travis |
bors
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
bors
added
S-waiting-on-bors
|
☀️ Test successful - status-appveyor, status-travis |
Fixes #51022